Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch kafka producer to use gatewayHost config #3388

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Switch kafka producer to use gatewayHost config #3388

merged 1 commit into from
Feb 11, 2025

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Feb 11, 2025

The host field was empty in our network events, since EthAcctAddr is not set, switch to gatewayHost that we're using elsewhere too.

@mjh1 mjh1 requested a review from gioelecerati February 11, 2025 14:07
@github-actions github-actions bot added the go Pull requests that update Go code label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.20719%. Comparing base (e7c416a) to head (1898848).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/livepeer/starter/kafka.go 0.00000% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3388         +/-   ##
===================================================
- Coverage   32.21282%   32.20719%   -0.00563%     
===================================================
  Files            147         147                 
  Lines          40636       40640          +4     
===================================================
- Hits           13090       13089          -1     
- Misses         26775       26779          +4     
- Partials         771         772          +1     
Files with missing lines Coverage Δ
cmd/livepeer/starter/kafka.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b675d4a...1898848. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/starter/kafka.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes

@mjh1 mjh1 merged commit 66ab0f9 into master Feb 11, 2025
20 checks passed
@mjh1 mjh1 deleted the mh/kafka branch February 11, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants